Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-205] Use BinaryType in GeometryUDT in Sedona Spark. #734

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

umartin
Copy link
Contributor

@umartin umartin commented Dec 14, 2022

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Use the more specialized type, BinaryType, in GeometryUDT for less overhead.

It seems that I stumbled upon the same flaky test as in #733. I will rebase this patch when the other PR is merged.

How was this patch tested?

All unit tests pass.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@umartin
Copy link
Contributor Author

umartin commented Dec 14, 2022

This is somewhat related to the awesome work by @Kontinuation in https://issues.apache.org/jira/browse/SEDONA-207
Although this patch only changes the Spark type once serialized and SEDONA-207 addresses the actual serialization.

@Kontinuation if you are already doing these changes in your work we can hold this PR

@Kontinuation
Copy link
Member

This is somewhat related to the awesome work by @Kontinuation in https://issues.apache.org/jira/browse/SEDONA-207 Although this patch only changes the Spark type once serialized and SEDONA-207 addresses the actual serialization.

@Kontinuation if you are already doing these changes in your work we can hold this PR

There is no conflict with my work in regard to this pull request, maybe we can go ahead and merge your PR first.

@jiayuasu
Copy link
Member

@umartin Martin, please rebase this PR and I will merge it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants