Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix failed Python CI caused by the release of Shapely 2.0 #732

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Dec 13, 2022

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

GeoPandas has Shapely as a hidden dependency with a version pattern shapely>=1.7: https://github.com/geopandas/geopandas/blob/main/requirements-dev.txt#L5

When pip installs GeoPandas, the latest shapely version will be installed automatically (if the user does not have one) as long as it is larger than 1.7.

Last night, Shapely publishes the 2.0 release which includes many breaking changes while GeoPandas only starts to support Shapely 2.0 in the latest GeoPandas 0.12

People who installs GeoPandas <0.12.0 will now have Shapely 2.0 install but the installed GeoPandas cannot work with it.

See the bug report I created on GeoPandas repo: geopandas/geopandas#2677

How was this patch tested?

Manually pin the Shapely version and passed CI

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu changed the title [DOCS] Fix failed Python CI [DOCS] Fix failed Python CI caused by the release of Shapely 2.0 Dec 13, 2022
@jiayuasu jiayuasu merged commit 8c319fa into master Dec 13, 2022
@jiayuasu jiayuasu deleted the fix-ci branch December 13, 2022 08:10
@jorisvandenbossche
Copy link
Member

Is there a reason you are pinning GeoPandas to exactly 0.6.0?
That is a very old release (>3 years)

@jiayuasu
Copy link
Member Author

@jorisvandenbossche You are right. We should have updated it to a newer version. Will do it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants