Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-204] Change Double.MIN_Value to -Double.MAX_Value #726

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

jiayuasu
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Change all Double.MIN_VALUE usage to -Double.MAX_VALUE because Double.MIN_VALUE returns a non-negative value while coordinates could be negative.

How was this patch tested?

Pass existing unit tests and add a test for negative coordinates.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu added this to the sedona-1.3.1 milestone Dec 12, 2022
@jiayuasu jiayuasu merged commit 7dbefc4 into master Dec 12, 2022
@jiayuasu jiayuasu deleted the SEDONA-204-init-xyz-max branch December 12, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant