[SEDONA-208] Use Spark RuntimeConfig in SedonaConf #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umartin
commented
Dec 2, 2022
| @@ -61,13 +61,9 @@ trait TraitJoinQueryExec extends TraitJoinQueryBase { | |||
| if (sedonaConf.getJoinApproximateTotalCount == -1) { | |||
| if (sedonaConf.getJoinSparitionDominantSide == JoinSparitionDominantSide.LEFT) { | |||
| leftShapes.analyze() | |||
| sedonaConf.setJoinApproximateTotalCount(leftShapes.approximateTotalCount) | |||
There was a problem hiding this comment.
These where set but never read
There was a problem hiding this comment.
I also forgot why it was set but not used...
jiayuasu
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Use dynamic runtime configuration in Sedona
How was this patch tested?
Unit tests added
Did this PR include necessary documentation updates?