[SEDONA-201] add ST_MPolyFromText and ST_MLineFromText methods #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Dec 2, 2022
docs/api/flink/Constructor.md
Outdated
|
|
||
| Format: `ST_MLineFromWKT (Text:string)` | ||
|
|
||
| Since: `1.3.0` |
There was a problem hiding this comment.
@jiayuasu I have made all the requested changes and have successfully run the test cases. Please let me know if any more changes are required.
| @@ -28,4 +28,20 @@ public static Geometry geomFromWKT(String wkt, int srid) throws ParseException { | |||
| GeometryFactory geometryFactory = new GeometryFactory(new PrecisionModel(), srid); | |||
| return new WKTReader(geometryFactory).read(wkt); | |||
| } | |||
|
|
|||
| public static Geometry mLineFromWKT(String wkt, int srid) throws ParseException { | |||
There was a problem hiding this comment.
The function names should be FromText, not FromWKT
| @@ -204,5 +204,15 @@ class constructorTestScala extends TestBaseScala { | |||
| var spatialRDD2 = Adapter.toSpatialRdd(df, "geometry") | |||
| Adapter.toDf(spatialRDD2, sparkSession).show(1) | |||
| } | |||
|
|
|||
| it("Passed ST_MLineFromWKT") { | |||
There was a problem hiding this comment.
Please add tests for the input with SRID
| @@ -185,4 +185,19 @@ public Geometry eval(@DataTypeHint("String") String kml) throws ParseException { | |||
| return new KMLReader().read(kml); | |||
| } | |||
| } | |||
|
|
|||
| public static class ST_MPolyFromWKT extends ScalarFunction { | |||
There was a problem hiding this comment.
Please create overload functions to take care of the inputs with SRID
| @@ -73,4 +73,11 @@ object st_constructors extends DataFrameAPI { | |||
|
|
|||
| def ST_PolygonFromText(coords: Column, delimiter: Column): Column = wrapExpression[ST_PolygonFromText](coords, delimiter) | |||
| def ST_PolygonFromText(coords: String, delimiter: String): Column = wrapExpression[ST_PolygonFromText](coords, delimiter) | |||
|
|
|||
| def ST_MPolyFromWKT(wkt: Column): Column = wrapExpression[ST_MPolyFromWKT](wkt, 0) | |||
| def ST_MPolyFromWKT(wkt: String): Column = wrapExpression[ST_MPolyFromWKT](wkt, 0) | |||
There was a problem hiding this comment.
Please handle the case with optional SRID
|
@gmaraswa ST_MakePolygon also uses an optional parameter. Please follow the way it handles optional parameters |
jiayuasu
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
What changes were proposed in this PR?
Implementation of ST_MLineFromText and ST_MPolyFromText
How was this patch tested?
Scala, Python, Java integration tests
Did this PR include necessary documentation updates?