Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-176] Make ST_Contains conform with OGC standard, and add ST_Covers and ST_CoveredBy functions. #698

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

Kontinuation
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • ST_Contains in Spark SQL module calls JTS function contains instead of covers.
  • Added ST_Covers, which calls JTS function covers.
  • Added ST_CoveredBy, which calls JTS function coveredBy.
  • Added dataframe functions for ST_Covers and ST_CoveredBy.

How was this patch tested?

Unit tests were added in this patch.

Did this PR include necessary documentation updates?

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great if you can add the same API to (1) Sedona Flink (2) Add the type-safe dataframe API to Sedona Python.

Thank you very much!

@jiayuasu jiayuasu merged commit ff2a4dd into apache:master Oct 9, 2022
@Kontinuation Kontinuation deleted the covers-and-covered-by branch October 10, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants