Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-172] Add ST_LineFromMultiPoint Function to SEDONA SQL API #695

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

AkshayGogeri
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

ST_LineFromMultiPoint Function

How was this patch tested?

Scala, Python, Java integration tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@@ -788,3 +788,22 @@ SELECT ST_Z(ST_POINT(0.0 25.0 11.0))
```

Output: `11.0`

## ST_LineFromMultiPoint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this function in an alphabetical order with other functions.

@@ -1394,3 +1394,29 @@ SELECT ST_Z(ST_POINT(0.0 25.0 11.0))
```

Output: `11.0`

## ST_LineFromMultiPoint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this function in an alphabetical order with other functions.

/**
* Returns the LineString geometry given a MultiPoint geometry
*
* @param inputExpressions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a DataFrame style API in Python and Scala for this function. See PR #693 .

@jiayuasu jiayuasu merged commit 3c082ff into apache:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants