Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-169] Fix ST_RemovePoint in accordance with the API document #691

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Sep 19, 2022

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

This PR fixes ST_RemovePoint to work without the second parameter, in accordance with its API document.

How was this patch tested?

Ran mvn clean install locally.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should move this logic to the Sedona common module?

@sekikn
Copy link
Contributor Author

sekikn commented Sep 19, 2022

Thank you for the review, as usual! I'll submit another PR later that adds the ST_AddPoint and ST_RemovePoint functions to Flink, so I'll move this logic into common in that PR.

@jiayuasu jiayuasu merged commit 9a1f545 into apache:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants