[SEDONA-125]Allows customized CRS in ST_Transform #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SW186000 This looks good. Can you also incorporate your change to ST_Transform in Sedona Flink? |
(compatible with Apache Flink)
|
Updated the PR |
jiayuasu
requested changes
Sep 11, 2022
| @@ -18,6 +18,7 @@ | |||
| import org.apache.sedona.common.utils.GeometryGeoHashEncoder; | |||
| import org.geotools.geometry.jts.JTS; | |||
| import org.geotools.referencing.CRS; | |||
| import org.jetbrains.annotations.Nullable; | |||
There was a problem hiding this comment.
@SW186000 The test failed. Please fix the Nullable annotation from "org.jetbrains.annotations"
(delete Nullable annotation)
Kimahriman
reviewed
Sep 11, 2022
Comment on lines
187
to
191
| public static Geometry transform(Geometry geometry, CoordinateReferenceSystem sourceCRS, CoordinateReferenceSystem targetCRS, boolean lenient) | ||
| throws FactoryException,TransformException { | ||
| MathTransform transform = CRS.findMathTransform(sourceCRS,targetCRS,lenient); | ||
| return JTS.transform(geometry, transform); | ||
| } |
There was a problem hiding this comment.
Sorry for reply.
I forgot deleting this function.
i will delete it.
Comment on lines
160
to
162
| else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Is this going to cause NPEs instead of throwing an exception explaining the string can't be parsed as a CRS?
flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java
Outdated
Show resolved
Hide resolved
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala
Outdated
Show resolved
Hide resolved
(delete needless function)
…/Functions.scala Co-authored-by: Adam Binford <adamq43@gmail.com>
Co-authored-by: Adam Binford <adamq43@gmail.com>
…ons.java Co-authored-by: Adam Binford <adamq43@gmail.com>
jiayuasu
reviewed
Sep 18, 2022
docs/api/sql/Function.md
Outdated
| @@ -1234,7 +1234,8 @@ MULTIPOLYGON (((-2 -3, -3 -3, -3 3, -2 3, -2 -3)), ((3 -3, 3 3, 4 3, 4 -3, 3 -3) | |||
|
|
|||
| Introduction: | |||
|
|
|||
| Transform the Spatial Reference System / Coordinate Reference System of A, from SourceCRS to TargetCRS | |||
| Transform the Spatial Reference System / Coordinate Reference System of A, from SourceCRS to TargetCRS. | |||
| For SourceCRS and TargetCRS, WKT format is also available. | |||
There was a problem hiding this comment.
Please add "since v1.3.1". Please also add the same sentence to the Flink SQL doc. Thank you!
(add exceptions)
(add exceptions)
(add doc comments)
|
@SW186000 Could you please fix the failed CI? |
|
@jiayuasu Sorry for late reply. I fix it. |
jiayuasu
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
add WKT support for ST_transform
How was this patch tested?
Scala unit test
Did this PR include necessary documentation updates?