Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-163] Better handle of unsupported types in shapefile reader #683

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Sep 7, 2022

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  1. Add information about all 14 types specified in Shapefile standard while Sedona only supports the most common types, POINT, POLYLINE, POLYGON and MULTIPOINT
  2. When skip an unsupported record, Sedona will prompt information about the unsupported type with WARN level log
  3. Add test data and update the LICENSE accordingly

How was this patch tested?

A test data in POLYGONZ format is added. Passed the unit test.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu added this to the sedona-1.3.0 milestone Sep 7, 2022
@jiayuasu jiayuasu merged commit c4e37ba into master Sep 7, 2022
@jiayuasu jiayuasu deleted the shapefile-better-explanation branch September 7, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant