Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-624] Bind references in distance expression to relations lazily to avoid exception in query plan canonicalization #1518

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Kontinuation
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

The query plan canonicalization phase creates temporary physical nodes whose attributes cannot be bound to relations, and then calls withNewChildren to replace the bad relations with the correct relations. DistanceJoinExec binds distance expression to the relation eagerly, which makes the physical node creation fail. We change the reference binding to be lazily evaluated to get rid of this problem.

How was this patch tested?

Add new tests that would fail without the fix.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jiayuasu jiayuasu added this to the sedona-1.6.1 milestone Jul 9, 2024
@jiayuasu jiayuasu added the bug label Jul 9, 2024
@jiayuasu jiayuasu merged commit 493ec74 into apache:master Jul 9, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants