[SEDONA-624] Bind references in distance expression to relations lazily to avoid exception in query plan canonicalization #1518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
The query plan canonicalization phase creates temporary physical nodes whose attributes cannot be bound to relations, and then calls withNewChildren to replace the bad relations with the correct relations.
DistanceJoinExec
binds distance expression to the relation eagerly, which makes the physical node creation fail. We change the reference binding to be lazily evaluated to get rid of this problem.How was this patch tested?
Add new tests that would fail without the fix.
Did this PR include necessary documentation updates?