[SEDONA-545] Sedona Python DataFrame API fail due to missing commas #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
added a commit
that referenced
this pull request
Apr 28, 2024
…1371) * Fix the bug * Fix a tiny issue
| @@ -43,3 +43,7 @@ | |||
| from sedona.raster_utils.SedonaUtils import SedonaUtils | |||
| from sedona.maps.SedonaKepler import SedonaKepler | |||
| from sedona.maps.SedonaPyDeck import SedonaPyDeck | |||
| from sedona.sql.st_aggregates import * | |||
| from sedona.sql.st_constructors import * | |||
| from sedona.sql.st_functions import * | |||
There was a problem hiding this comment.
This introduces another problem: st_functions defines a function named GeometryType, it replaces the previously imported from sedona.sql.types import GeometryType. I prefer not importing the GeometryType function when from sedona.sql.st_functions import * to preserve backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-545] my subject.What changes were proposed in this PR?
__all__auto populate all functions in the filefrom sedona.spark import *will also include Python DataFrame functionsHow was this patch tested?
Passed local import tests
Did this PR include necessary documentation updates?