Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-527] Add pre-commit hook check-json; Lint JSON files #1311

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Apr 3, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Added another hook to our pre-commit framework:

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-json

How was this patch tested?

With the new hook check-json added I first ran locally:

pre-commit run --all-files

which showed the JSON files that weren't valid JSON.

Then checked some JSON with JSON Lint online.

https://jsonlint.com/

Then fixed the JSON to be valid JSON.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jbampton jbampton marked this pull request as draft April 3, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant