-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-441] Add ST_LineLocatePoint #1178
Conversation
…-ST_LineLocatePoint # Conflicts: # python/tests/sql/test_dataframe_api.py
docs/api/flink/Function.md
Outdated
|
||
Since: `v1.5.1` | ||
|
||
Spark SQL Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not Spark SQL
. It is SQL
Double expectedResult2 = 0.5; | ||
Double expectedResult3 = 1.0; | ||
|
||
assertEquals(expectedResult1, actual1, 0.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe our TestBase already has a variable called FP Tolerance
@@ -771,12 +779,6 @@ public void testRemovePointWithIndex() { | |||
assertEquals("LINESTRING (0 0, 2 2)", first(pointTable).getField(0).toString()); | |||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this test?
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
Adds Vector function ST_LineLocatePoint
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Z
format.