[SEDONA-369] Add ST_DWithin #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Jan 1, 2024
| @@ -49,4 +49,11 @@ public static boolean disjoint(Geometry leftGeometry, Geometry rightGeometry) { | |||
| public static boolean orderingEquals(Geometry leftGeometry, Geometry rightGeometry) { | |||
| return leftGeometry.equalsExact(rightGeometry); | |||
| } | |||
| public static boolean dWithin(Geometry leftGeometry, Geometry rightGeometry, double distance) { | |||
| int leftSrid = leftGeometry.getSRID(), rightSrid = rightGeometry.getSRID(); | |||
There was a problem hiding this comment.
I suggest that we don't perform CRS check in Predicates because all other predicates do not check it.
If we want to enforce this check, please raise another PR for this specific issue. Moreover, what is the default value of SRID if the user don't specify it at all? I think it is 0? If so, this check will work. If it is null, then this check will not work.
jiayuasu
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.