Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-429][SEDONA-430] Support specifying GeoParquet spec version number and CRS #1162

Merged
merged 10 commits into from
Jan 2, 2024

Conversation

Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Dec 27, 2023

Note: This PR depends on #1161

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Bumped the default GeoParquet version number from 1.0.0-beta.1 to 1.0.0
  • Allow specifying GeoParquet version number using geoparquet.version option
  • Allow specifying CRS metadata for geometry columns using geoparquet.crs option

How was this patch tested?

Add new tests for GeoParquet metadata.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@Kontinuation Kontinuation changed the title [SEDONA-429][SEDONA-430] Support specifying GeoParquet spec version number and CRS [SEDONA-429,SEDONA-430] Support specifying GeoParquet spec version number and CRS Dec 27, 2023
@Kontinuation Kontinuation changed the title [SEDONA-429,SEDONA-430] Support specifying GeoParquet spec version number and CRS [SEDONA-429][SEDONA-430] Support specifying GeoParquet spec version number and CRS Dec 27, 2023
@Kontinuation Kontinuation marked this pull request as ready for review December 27, 2023 05:16
@@ -14,12 +14,7 @@
package org.apache.spark.sql.execution.datasources.parquet

Copy link
Member

@jiayuasu jiayuasu Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a new data source to only read the metadata of a parquet file? This is crucial for entry-level users to explore an unknown parquet file including geoparquet. In our geoparquet case, this will help user know the projjson value since we are not able to properly parse it to a known epsg code.

I understand that a Spark DataFrame only allows the schema to be the metadata which cannot be used to hold such information.

So I suggest that we add a new data source namely geoparquet.metadata, which loads these metadata using ParquetFileReader. One good example is from DuckDB: https://duckdb.org/docs/data/parquet/metadata.html

This can be addressed in a separate PR.

Copy link
Member

@jiayuasu jiayuasu Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a JIRA ticket for this: https://issues.apache.org/jira/browse/SEDONA-455

Let's address this in a separate PR.

docs/tutorial/sql.md Show resolved Hide resolved
@Kontinuation Kontinuation marked this pull request as draft December 29, 2023 01:03
@Kontinuation Kontinuation marked this pull request as ready for review December 29, 2023 14:03
docs/tutorial/sql.md Show resolved Hide resolved
@jiayuasu jiayuasu merged commit 4140594 into apache:master Jan 2, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants