Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-444] pre-commit: add hook to trim trailing whitespace #1144

Merged

Conversation

jbampton
Copy link
Member

https://github.com/pre-commit/pre-commit-hooks#trailing-whitespace

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Adds another hook to our pre-commit framework that will trim trailing whitespace from files when run locally.

Just pass or fail when run with GitHub actions.

We don't need all this extra whitespace at the end of lines.

How was this patch tested?

pre-commit run trailing-whitespace --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu merged commit 5ae8243 into apache:master Dec 14, 2023
40 checks passed
@jbampton jbampton deleted the add-hook-to-trim-trailing-whitespace branch December 14, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants