Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-442] pre-commit: add hook markdown-lint #1141

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jbampton
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

This pr adds another hook to our pre-commit framework to check the Markdown files.

https://github.com/igorshubovych/markdownlint-cli#use-with-pre-commit

https://github.com/DavidAnson/markdownlint

I have disabled a whole bunch of rules.

Going forwards we can work on our "Markdown" files and standardize them.

How was this patch tested?

pre-commit run --all-files

or

pre-commit run markdownlint --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu jiayuasu merged commit 8cbe4f8 into apache:master Dec 13, 2023
34 of 40 checks passed
@jbampton jbampton deleted the add-markdownlint-with-pre-commit branch December 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants