[SEDONA-193] Add Sedona NetCDF reader suite #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/src/main/java/org/apache/sedona/common/raster/MapAlgebra.java # common/src/main/java/org/apache/sedona/common/raster/RasterConstructors.java # common/src/main/java/org/apache/sedona/common/utils/RasterUtils.java # common/src/test/java/org/apache/sedona/common/raster/RasterTestBase.java
iGN5117
changed the title
jiayuasu
requested changes
Dec 5, 2023
| @@ -31,6 +31,8 @@ | |||
| */ | |||
| package org.apache.sedona.core.formatMapper.netcdfParser; | |||
|
|
|||
| import org.geotools.coverage.grid.GridCoverage2D; | |||
There was a problem hiding this comment.
Why add these imports since they are not used anyway?
There was a problem hiding this comment.
Removed this, this was part of my original work push to netcdf branch
spark/common/src/test/scala/org/apache/sedona/sql/rasteralgebraTest.scala
Outdated
Show resolved
Hide resolved
common/src/test/java/org/apache/sedona/common/raster/RasterTestBase.java
Outdated
Show resolved
Hide resolved
common/src/test/java/org/apache/sedona/common/raster/RasterTestBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Please do not add Sedona in the file name / class name.
common/src/main/java/org/apache/sedona/common/raster/netcdf/SedonaNetCdfReader.java
Outdated
Show resolved
Hide resolved
…dona into develop_Nilesh_NetCDF
jiayuasu
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.