Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-437] Add implicit CRS transformation #1133

Merged
merged 18 commits into from
Dec 5, 2023

Conversation

furqaankhan
Copy link
Contributor

@furqaankhan furqaankhan commented Nov 29, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • All raster functions that take a geometry, should implicitly transform the CRS of the geometry if needed.
  • The default CRS for these functions should be 4326 for raster and geometry both.

How was this patch tested?

  • passed existing and new tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@furqaankhan furqaankhan marked this pull request as ready for review November 29, 2023 16:36
@jiayuasu
Copy link
Member

@furqaankhan Please address the confligc

@jiayuasu
Copy link
Member

jiayuasu commented Dec 3, 2023

@furqaankhan Please fix the R raster test by using ST_SetSRID(ST_Point(XXX, XXX), RS_SRID(raster)). This way, you don't have to change the test output.

@jiayuasu
Copy link
Member

jiayuasu commented Dec 3, 2023

@Kontinuation Please review. Note that: when either geometry or raster has srid == 0, we assume it is in 4326 and set their SRID accordingly.

@jiayuasu jiayuasu merged commit 815860c into apache:master Dec 5, 2023
34 of 40 checks passed
@furqaankhan furqaankhan deleted the rs-implicit-transform branch July 16, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants