[SEDONA-431] Add RS_PixelAsPoints #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Nov 21, 2023
common/src/main/java/org/apache/sedona/common/raster/PixelFunctions.java
Show resolved
Hide resolved
common/src/test/java/org/apache/sedona/common/raster/FunctionsTest.java
Outdated
Show resolved
Hide resolved
jiayuasu
requested changes
Nov 22, 2023
| @@ -931,6 +931,25 @@ class rasteralgebraTest extends TestBaseScala with BeforeAndAfter with GivenWhen | |||
| assertEquals(expectedY, actualCoordinates.y, 1e-5) | |||
| } | |||
|
|
|||
| it("Passed RS_PixelAsPoints with empty raster") { | |||
There was a problem hiding this comment.
Please add a test with Spark explode function and make sure the output of this function can work seamlessly with explode.
jiayuasu
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.