[SEDONA-421] Add RS_Clip #1078
Merged
[SEDONA-421] Add RS_Clip #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of a new raster
… creation of a new raster" This reverts commit 7edb62b.
jiayuasu
requested changes
Nov 8, 2023
| // * @param crop Specifies to keep the original extent or not | ||
| // * @return A clip Raster with defined ROI by the geometry | ||
| // */ | ||
| // public static GridCoverage2D clip(GridCoverage2D raster, int band, Geometry geometry, boolean crop) { |
There was a problem hiding this comment.
I thought to keep it when we can support same arity functions. We can uncomment it and use it. Do let me know if you still want them to be removed.
| // this will shrink the extent of the raster to the geometry | ||
| Crop cropObject = new Crop(); | ||
| ParameterValueGroup parameters = cropObject.getParameters(); | ||
| parameters.parameter("Source").setValue(singleBandRaster); |
There was a problem hiding this comment.
Does this have to be a single band?
There was a problem hiding this comment.
It can be either single or all bands. How do you want me to implement it?
| @@ -69,6 +73,23 @@ public void testSetBandNoDataValueWithEmptyRasterMultipleBand() throws FactoryEx | |||
| assertEquals(444, (double) RasterBandAccessors.getBandNoDataValue(grid, 2), 0.1d); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testClip() throws IOException, FactoryException, TransformException, ParseException { | |||
| GridCoverage2D raster = rasterFromGeoTiff(resourceFolder + "raster_geotiff_color/FAA_UTM18N_NAD83.tif"); | |||
There was a problem hiding this comment.
Please add tests to try with crop == true. In addition, please also test if the pixels of a raster are successfully masked.
jiayuasu
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?