[SEDONA-415] Add optional parameter to ST_Transform #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Nov 1, 2023
docs/api/sql/Function.md
Outdated
| @@ -2530,7 +2530,7 @@ PROJCS["WGS 84 / Pseudo-Mercator", | |||
| Format: | |||
|
|
|||
| ``` | |||
| ST_Transform (A: Geometry, SourceCRS: String, TargetCRS: String, [Optional] lenientMode: Boolean) | |||
| ST_Transform (A: Geometry, [Optional] SourceCRS: String, TargetCRS: String, [Optional] lenientMode: Boolean) | |||
There was a problem hiding this comment.
Please provide overloaded variants of this function. Don't just specify optional.
python/sedona/sql/st_functions.py
Outdated
There was a problem hiding this comment.
New Python DataFrame API needs to be tested.
jiayuasu
requested changes
Nov 2, 2023
python/tests/sql/test_function.py
Outdated
| function_df = self.spark.sql( | ||
| "select ST_Transform(polygondf.countyshape, 'epsg:3857', false) from polygondf" | ||
| ) | ||
| function_df.show() |
There was a problem hiding this comment.
Same thing here. Do not do show. Use assertion to check the correctness
jiayuasu
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
sourceCRSan optional parameterHow was this patch tested?
Did this PR include necessary documentation updates?