[SEDONA-411] Add RS_Rotation #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@furqaankhan Is the result identical to PostGIS? |
|
Yes it is. |
|
@jiayuasu I want to get Kristin's opinion before merging, so don't merge yet. |
jiayuasu
requested changes
Oct 30, 2023
| } | ||
|
|
||
| // Angular separation | ||
| thetaIJ = Math.acos((((scaleX * skewX) + (skewY * scaleY)) / (magnitudeI * magnitudeJ))); |
There was a problem hiding this comment.
can magnitude be zero or other invalid values? If so, we need to add handlers and test cases.
Kontinuation
requested changes
Oct 31, 2023
Comment on lines
147
to
151
| // x ordinate of the upper-left corner of the upper-left pixel | ||
| double offsetX = renderedImage.getTileGridXOffset(); | ||
|
|
||
| // y ordinate of the upper-left corner of the upper-left pixel | ||
| double offsetY = renderedImage.getTileGridYOffset(); |
There was a problem hiding this comment.
This is not correct. offsetX and offsetY should be directly retrieved from the upperLeftX and upperLeftY components of the raster metadata.
| public void testGeoTransform() throws FactoryException { | ||
| GridCoverage2D emptyRaster = RasterConstructors.makeEmptyRaster(1, 10, 15, 1, 2, 1, -1, 10, 10, 0); | ||
| double[] actual = RasterAccessors.getGeoTransform(emptyRaster); | ||
| double[] expected = new double[] {10.04987562112089, 10.04987562112089, -1.4711276743037347, -1.5707963267948966, 0.0, 0.0}; |
There was a problem hiding this comment.
We are getting 0 offsets for rasters with non-zero offsets, this is caused by the problem mentioned above.
jiayuasu
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?