Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update binder notebook examples #1056

Merged
merged 28 commits into from
Nov 2, 2023

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Oct 23, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

  • Update sedona and geotools version in binder notebook examples
  • Updated visualization to use SedonaKepler
  • Added tutorial for Uber H3 cell visualization.

How was this patch tested?

  • Ran notebooks

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

python/Pipfile Outdated
@@ -14,7 +14,7 @@ pytest-cov = "*"
shapely="<=1.8.5"
pandas="<=1.3.5"
geopandas="<=0.10.2"
pyspark=">=2.3.0"
pyspark="*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to pyspark=">=3.0.0"

examples/spark-viz/build.sbt Outdated Show resolved Hide resolved
binder/ApacheSedonaRaster.ipynb Outdated Show resolved Hide resolved
binder/ApacheSedonaSQL.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the 2 maven coordinates here:
image

python/Pipfile Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the change of this file as it is not related to the binder notebooks.

@@ -46,7 +46,7 @@ val ScalaCompatibleVersion = "2.12"
// Change the dependency scope to "provided" when you run "sbt assembly"
val dependencyScope = "compile"

val geotoolsVersion = "1.4.0-28.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the change of this file as it is not related to the binder notebooks.

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

binder/postBuild Show resolved Hide resolved
@iGN5117 iGN5117 added the docs label Nov 1, 2023
@iGN5117 iGN5117 modified the milestone: sedona-1.5.1 Nov 1, 2023
@jiayuasu jiayuasu merged commit 3412696 into apache:master Nov 2, 2023
30 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants