Improve Samza AM retry count logging #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* print current timestamp * Fix typo * fix build issue about grolifant okhttp --------- Co-authored-by: Haolan Ye <hye@linkedin.com>
This reverts commit 1e84ac0.
dxichen
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LISAMZA-43659
Description: According to
org/apache/samza/clustermanager/ContainerProcessManager.java:520The rules to shut down the whole app if too many container failures have happened:
Issue:
org/apache/samza/clustermanager/ContainerProcessManager.java:575doesn't reflect point 2 of the counting behavior wellFix: Add to the logs information about point 2