[improve][build] Support git worktree working directory while building docker images #22851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Jun 5, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…g docker images (apache#22851) (cherry picked from commit c23e677) (cherry picked from commit 9d09daf)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…g docker images (apache#22851) (cherry picked from commit c23e677) (cherry picked from commit 9d09daf)
lhotari
added a commit
to apache/pulsar-site
that referenced
this pull request
Jun 9, 2024
- issue was fixed by apache/pulsar#22851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
git supports sharing a single local directory across multiple working directories as explained in https://pulsar.apache.org/contribute/setup-git/#checking-out-each-pulsar-maintenance-branch-in-a-separate-working-directory . This makes it easier to maintain multiple Pulsar branches since each maintenance branch will be checked out in it's own working directory and could be open simultaneously in IntelliJ.
However, building docker images has been broken when using
git worktreeworking directory. This is fixed with this PR.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete