[fix] [broker] fix topic partitions was expanded even if disabled topic level replication #22769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic level replication
poorbarcode
added
type/bug
Technoboy-
approved these changes
May 24, 2024
|
/pulsarbot rerun-failure-checks |
gaoran10
approved these changes
May 24, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Outdated
Show resolved
Hide resolved
hanmz
approved these changes
May 27, 2024
Demogorgon314
approved these changes
May 27, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 31, 2024
…ic level replication (apache#22769) (cherry picked from commit 55ad4b2) (cherry picked from commit 96e2bda)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…ic level replication (apache#22769) (cherry picked from commit 55ad4b2) (cherry picked from commit 96e2bda)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…ic level replication (apache#22769) (cherry picked from commit 55ad4b2) (cherry picked from commit 96e2bda)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…ic level replication (apache#22769) (cherry picked from commit 55ad4b2) (cherry picked from commit 96e2bda)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The topic partitions on the remote cluster will be expanded when namespace level Geo-Replication is enabled, even if the topic level Geo-Replication is disabled. It is not correct.
The topic partitions on the remote cluster will not be expanded if the topic level Geo-Replication is enabled. It is not correct.
Modifications
Fix the two issues.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x