[improve][client] Add schema typing to consumer and producer #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
approved these changes
Jan 5, 2023
RobertIndie
reviewed
Jan 10, 2023
|
@RobertIndie |
k2la
requested changes
Jan 20, 2023
index.d.ts
Outdated
| @@ -236,3 +245,21 @@ export type ConsumerCryptoFailureAction = | |||
| 'FAIL' | | |||
| 'DISCARD' | | |||
| 'CONSUME'; | |||
|
|
|||
| export type SchemaType = | |||
There was a problem hiding this comment.
Suggested change
| export type SchemaType = | |
| export type SchemaType = |
|
@romainbrancourt |
romainbrancourt
requested review from
RobertIndie and
k2la
and removed request for
RobertIndie
k2la
approved these changes
Jan 24, 2023
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Add schema typing to consumer and producer
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)