-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add record availability lag for Kafka connector #9621
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9621 +/- ##
============================================
- Coverage 35.02% 34.95% -0.08%
Complexity 189 189
============================================
Files 1943 1943
Lines 103817 103841 +24
Branches 15743 15744 +1
============================================
- Hits 36361 36293 -68
- Misses 64369 64448 +79
- Partials 3087 3100 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b13c20f
to
5690659
Compare
5690659
to
2b4a535
Compare
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionLagState.java
Outdated
Show resolved
Hide resolved
2b4a535
to
16ca0d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to keep the json property and variable name the same
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
Outdated
Show resolved
Hide resolved
pinot-server/src/main/java/org/apache/pinot/server/api/resources/DebugResource.java
Outdated
Show resolved
Hide resolved
...ka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java
Outdated
Show resolved
Hide resolved
...afka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConsumerPartitionLag.java
Outdated
Show resolved
Hide resolved
...afka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConsumerPartitionLag.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java
Outdated
Show resolved
Hide resolved
We may also pick a shorter name for them to be more concise, but let's keep the name consistent across classes:
|
16ca0d8
to
1784131
Compare
86af551
to
f374edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduces record availability lag for realtime connectors via the rest apis -
consumingSegmentsInfo
and
/debug/tables/{tableName}
Label:
release-notes
/consumingSegmentsInfo
anddebug/tables/{tableName}
API now provides the following per-partition numbers for Kafka data sources:currentConsumingOffset
,latestUpstreamOffset
,recordsLag
,availabilityLagMs