-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ParquetNativeRecordReader to have all the types to support #9352
Conversation
xiangfu0
commented
Sep 9, 2022
- Restructure the types to implement for Parquet data type converter
- Adding more test cases for parquet files
b5cf587
to
1d3e335
Compare
Codecov Report
@@ Coverage Diff @@
## master #9352 +/- ##
=============================================
- Coverage 69.80% 26.13% -43.67%
+ Complexity 4777 44 -4733
=============================================
Files 1875 1872 -3
Lines 99860 99914 +54
Branches 15194 15212 +18
=============================================
- Hits 69706 26115 -43591
- Misses 25231 71180 +45949
+ Partials 4923 2619 -2304
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3ec277f
to
ab614b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check in so many test files? Having a test file with all the field type should be enough?
Those are various small parquet files from: I copied over them and wanna make sure we pass all of them until we found a better test plan. We still have files don't support yet e.g. compression lib missing or encryption methods etc. |
ab614b5
to
4abbb9c
Compare