Add Support for Cast Function on MV Columns #9296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java
Outdated
Show resolved
Hide resolved
siddharthteotia
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9296 +/- ##
============================================
- Coverage 28.44% 26.08% -2.37%
+ Complexity 53 44 -9
============================================
Files 1861 1861
Lines 99226 99473 +247
Branches 15123 15144 +21
============================================
- Hits 28225 25946 -2279
- Misses 68272 70924 +2652
+ Partials 2729 2603 -126
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SabrinaZhaozyf
commented
Aug 30, 2022
...c/test/java/org/apache/pinot/core/operator/transform/function/CastTransformFunctionTest.java
Show resolved
Hide resolved
SabrinaZhaozyf
changed the title
|
Yet to review the main logic. Thanks for addressing the main concern of INTMV v/s INT |
somandal
reviewed
Aug 31, 2022
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/apache/pinot/core/operator/transform/function/CastTransformFunctionTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label:
featureThis PR adds support for Cast transform function for mv columns.