Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server query cancellation and timeout checking during execution #9286

Conversation

jasperjiaguo
Copy link
Contributor

  1. check for interruption during group-by merge, for each 10_000 keys
  2. check for timeout during the mergeResults()

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #9286 (b4d9ba5) into master (88bb40c) will decrease coverage by 7.17%.
The diff coverage is 21.66%.

❗ Current head b4d9ba5 differs from pull request most recent head 1a04903. Consider uploading reports for the commit 1a04903 to get more accurate results

@@             Coverage Diff              @@
##             master    #9286      +/-   ##
============================================
- Coverage     68.42%   61.24%   -7.18%     
+ Complexity     5016     4868     -148     
============================================
  Files          1864     1855       -9     
  Lines         99469    99272     -197     
  Branches      15133    15112      -21     
============================================
- Hits          68060    60798    -7262     
- Misses        26560    33843    +7283     
+ Partials       4849     4631     -218     
Flag Coverage Δ
integration1 26.08% <10.00%> (?)
integration2 ?
unittests1 67.09% <65.07%> (-0.01%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../pinot/broker/api/resources/PinotBrokerLogger.java 0.00% <0.00%> (ø)
...a/org/apache/pinot/common/metrics/ServerMeter.java 100.00% <ø> (ø)
...pache/pinot/common/utils/config/InstanceUtils.java 78.04% <0.00%> (-16.32%) ⬇️
...org/apache/pinot/common/utils/http/HttpClient.java 68.13% <ø> (-6.05%) ⬇️
...ontroller/api/resources/PinotControllerLogger.java 0.00% <0.00%> (ø)
.../pinot/core/data/manager/BaseTableDataManager.java 73.22% <ø> (-0.34%) ⬇️
...core/operator/blocks/IntermediateResultsBlock.java 84.79% <ø> (-1.68%) ⬇️
.../pinot/minion/api/resources/PinotMinionLogger.java 0.00% <0.00%> (ø)
.../pinot/server/api/resources/PinotServerLogger.java 0.00% <0.00%> (ø)
.../helix/FreshnessBasedConsumptionStatusChecker.java 0.00% <0.00%> (ø)
... and 451 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasperjiaguo jasperjiaguo marked this pull request as ready for review August 26, 2022 23:20
@jasperjiaguo jasperjiaguo changed the title [WIP] Improve server query cancellation and timeout checking during execution Improve server query cancellation and timeout checking during execution Aug 26, 2022
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@siddharthteotia siddharthteotia merged commit 15b16e8 into apache:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants