Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use aggregation result for distinct query in IntermediateResultsBlock #9262

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #9262 (a1748dc) into master (718f41f) will increase coverage by 1.18%.
The diff coverage is 87.80%.

@@             Coverage Diff              @@
##             master    #9262      +/-   ##
============================================
+ Coverage     68.75%   69.94%   +1.18%     
- Complexity     4755     5009     +254     
============================================
  Files          1859     1859              
  Lines         99129    99146      +17     
  Branches      15077    15078       +1     
============================================
+ Hits          68161    69343    +1182     
+ Misses        26076    24900    -1176     
- Partials       4892     4903      +11     
Flag Coverage Δ
integration1 26.27% <85.36%> (-0.16%) ⬇️
integration2 24.77% <85.36%> (?)
unittests1 67.10% <87.80%> (+0.02%) ⬆️
unittests2 15.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perator/query/DictionaryBasedDistinctOperator.java 76.08% <33.33%> (-1.00%) ⬇️
...core/operator/combine/DistinctCombineOperator.java 86.36% <77.77%> (+2.36%) ⬆️
...core/operator/blocks/IntermediateResultsBlock.java 86.46% <96.15%> (+1.38%) ⬆️
...he/pinot/core/operator/query/DistinctOperator.java 96.29% <100.00%> (-0.26%) ⬇️
...apache/pinot/broker/api/HttpRequesterIdentity.java 28.57% <0.00%> (-57.15%) ⬇️
...org/apache/pinot/broker/api/RequesterIdentity.java 50.00% <0.00%> (-50.00%) ⬇️
...ntroller/helix/core/minion/TaskMetricsEmitter.java 34.88% <0.00%> (-41.87%) ⬇️
.../predicate/NotEqualsPredicateEvaluatorFactory.java 66.34% <0.00%> (-7.70%) ⬇️
...a/org/apache/pinot/common/utils/ServiceStatus.java 60.95% <0.00%> (-7.62%) ⬇️
...roller/helix/core/relocation/SegmentRelocator.java 72.97% <0.00%> (-5.41%) ⬇️
... and 139 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit fad3de8 into apache:master Aug 22, 2022
@Jackie-Jiang Jackie-Jiang deleted the distinct_results_block branch August 22, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants