-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show most recent scheduling errors #9161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9161 +/- ##
=============================================
- Coverage 60.15% 28.40% -31.76%
+ Complexity 4862 53 -4809
=============================================
Files 1836 1845 +9
Lines 98217 98791 +574
Branches 14928 15040 +112
=============================================
- Hits 59086 28059 -31027
- Misses 34704 68035 +33331
+ Partials 4427 2697 -1730
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cc @saurabhd336 |
@joshigaurava please help review |
Please eliminate code that is no longer required rather than simply commenting it out. |
@npawar, Server is sending PreviousFireTime and NextFireTime in epoch format that's why creating date object from that UI shows user's local time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm functionally
Will merge once @joshigaurava approves |
pinot-controller/src/main/resources/app/pages/TaskQueueTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous comment was to remove unused code. It's just that I didn't point all the places where we need to remove unused code. Please go through the entire PR and remove the code instead of commenting it out.
@satishwaghela can you please post an updated screenshot? For a UI change, it helps in correlating code with the output. |
|
On the TaskName->TableName page, the SCHEDULING ERRORS was previously TBD. Now we have the API for it: GET /tasks/generator/{tableNameWithType}/{taskType}/debug