Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints for some finer control on minion tasks #8486

Merged

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Apr 7, 2022

add endpoints for some finer control on minion tasks:

  • inspect the states or configs of the subtasks of a task
  • allow to delete individual tasks w/o deleting the task queue

Release Notes

Added 3 http endpoints for inspecting and operating the minion tasks

  • /tasks/subtask/{taskName}/state to get the states of the subtasks of a task
  • /tasks/subtask/{taskName}/config to get the configs of the subtasks of a task
  • /tasks/task/{taskName} to delete a task and all its subtasks

- allow to delete individual tasks w/o deleting the task queue
- inspect the states or configs of the subtasks of a task
@klsince klsince force-pushed the few_finer_controlls_on_minion_tasks branch from 4b925e5 to a890ce6 Compare April 7, 2022 22:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #8486 (16340f7) into master (6849441) will increase coverage by 41.46%.
The diff coverage is 12.50%.

@@              Coverage Diff              @@
##             master    #8486       +/-   ##
=============================================
+ Coverage     29.15%   70.61%   +41.46%     
- Complexity        0     4280     +4280     
=============================================
  Files          1660     1672       +12     
  Lines         87082    87476      +394     
  Branches      13194    13240       +46     
=============================================
+ Hits          25386    61770    +36384     
+ Misses        59367    21410    -37957     
- Partials       2329     4296     +1967     
Flag Coverage Δ
integration1 27.03% <12.50%> (-0.04%) ⬇️
integration2 26.07% <0.00%> (+0.22%) ⬆️
unittests1 66.99% <ø> (?)
unittests2 14.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roller/api/resources/PinotTaskRestletResource.java 0.00% <0.00%> (ø)
...lix/core/minion/PinotHelixTaskResourceManager.java 40.47% <13.88%> (-3.71%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 85.31% <0.00%> (-2.10%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 47.66% <0.00%> (-2.08%) ⬇️
...r/helix/SegmentOnlineOfflineStateModelFactory.java 58.49% <0.00%> (-1.89%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
...in/stream/kafka20/KafkaPartitionLevelConsumer.java 66.66% <0.00%> (ø)
...ker/api/resources/BrokerEchoWithAutoDiscovery.java 0.00% <0.00%> (ø)
...pache/pinot/core/api/AutoLoadedServiceForTest.java 0.00% <0.00%> (ø)
... and 1160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6849441...16340f7. Read the comment docs.

@klsince klsince force-pushed the few_finer_controlls_on_minion_tasks branch from a890ce6 to 16340f7 Compare April 8, 2022 16:37
@Jackie-Jiang Jackie-Jiang added the release-notes Referenced by PRs that need attention when compiling the next release notes label Apr 8, 2022
@Jackie-Jiang Jackie-Jiang merged commit 8e21aec into apache:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants