Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ScalarFunction annotation from name to names to support alias #8252

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 25, 2022

Description

#8236

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #8252 (50160a1) into master (a1d440b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8252      +/-   ##
============================================
- Coverage     70.77%   70.75%   -0.02%     
- Complexity     4241     4242       +1     
============================================
  Files          1629     1631       +2     
  Lines         85193    85281      +88     
  Branches      12825    12845      +20     
============================================
+ Hits          60292    60343      +51     
- Misses        20740    20775      +35     
- Partials       4161     4163       +2     
Flag Coverage Δ
integration1 28.81% <100.00%> (-0.10%) ⬇️
integration2 27.52% <100.00%> (+<0.01%) ⬆️
unittests1 66.98% <100.00%> (+<0.01%) ⬆️
unittests2 14.13% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apache/pinot/common/function/FunctionRegistry.java 93.93% <100.00%> (+6.84%) ⬆️
...nt/local/startree/v2/store/StarTreeDataSource.java 40.00% <0.00%> (-13.34%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 47.66% <0.00%> (-10.89%) ⬇️
.../api/exception/ControllerApplicationException.java 66.66% <0.00%> (-6.67%) ⬇️
...ot/segment/local/startree/OffHeapStarTreeNode.java 72.22% <0.00%> (-5.56%) ⬇️
...ntroller/helix/core/minion/TaskMetricsEmitter.java 86.36% <0.00%> (-4.55%) ⬇️
...verter/stats/MutableNoDictionaryColStatistics.java 40.90% <0.00%> (-4.10%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 87.41% <0.00%> (-3.50%) ⬇️
.../loader/defaultcolumn/DefaultColumnStatistics.java 73.07% <0.00%> (-2.93%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 77.65% <0.00%> (-2.13%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d440b...50160a1. Read the comment docs.

@xiangfu0 xiangfu0 merged commit d999aec into apache:master Feb 26, 2022
@xiangfu0 xiangfu0 deleted the scalar-alias branch February 26, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalar Functions should be able to support multiple names
3 participants