Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TLS configs and utils from pinot-core to pinot-common #8210

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 16, 2022

Description

So TLS configs can be reused by the gRPC client as well

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Backward incompatible for 3rd party code extension:
TlsUtils is moved from org.apache.pinot.core.util.TlsUtils to org.apache.pinot.common.utils.TlsUtils

Documentation

@xiangfu0 xiangfu0 force-pushed the move_tls_configs_to_common branch 2 times, most recently from 2d17ffc to f79499d Compare February 16, 2022 21:03
@codecov-commenter
Copy link

Codecov Report

Merging #8210 (675acc0) into master (8042408) will decrease coverage by 56.84%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8210       +/-   ##
=============================================
- Coverage     70.97%   14.12%   -56.85%     
+ Complexity     4313       81     -4232     
=============================================
  Files          1626     1581       -45     
  Lines         84851    83048     -1803     
  Branches      12790    12579      -211     
=============================================
- Hits          60221    11730    -48491     
- Misses        20496    70438    +49942     
+ Partials       4134      880     -3254     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/pinot/broker/broker/helix/BaseBrokerStarter.java 71.89% <ø> (-3.79%) ⬇️
...roker/requesthandler/GrpcBrokerRequestHandler.java 0.00% <ø> (-78.58%) ⬇️
...thandler/SingleConnectionBrokerRequestHandler.java 12.96% <ø> (-74.08%) ⬇️
...java/org/apache/pinot/common/config/TlsConfig.java 0.00% <ø> (ø)
...n/java/org/apache/pinot/common/utils/TlsUtils.java 0.00% <ø> (ø)
...apache/pinot/controller/BaseControllerStarter.java 78.98% <ø> (-3.19%) ⬇️
...rg/apache/pinot/core/transport/ListenerConfig.java 0.00% <ø> (-100.00%) ⬇️
...a/org/apache/pinot/core/transport/QueryRouter.java 0.00% <ø> (-87.96%) ⬇️
...a/org/apache/pinot/core/transport/QueryServer.java 0.00% <ø> (-74.47%) ⬇️
...rg/apache/pinot/core/transport/ServerChannels.java 0.00% <ø> (-89.84%) ⬇️
... and 1307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8042408...675acc0. Read the comment docs.

Copy link
Contributor

@apucher apucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side.

However, I'd add to the release notes that this could break 3rd party code extension that use TlsUtils

@xiangfu0 xiangfu0 merged commit 39254e4 into apache:master Feb 16, 2022
@xiangfu0 xiangfu0 deleted the move_tls_configs_to_common branch February 16, 2022 22:27
xiangfu0 added a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants