adding instant deletion option for segment deletion #8122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
force-pushed
the
instant_delete_segment_api
branch
from
8c566e5
to
61076f5
Compare
mcvsubbu
reviewed
Feb 3, 2022
| @@ -571,12 +571,15 @@ public SuccessResponse reloadAllSegmentsDeprecated2( | |||
| @ApiOperation(value = "Delete a segment", notes = "Delete a segment") | |||
| public SuccessResponse deleteSegment( | |||
| @ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableName, | |||
| @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") @Encoded String segmentName) { | |||
| @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") @Encoded String segmentName, | |||
| @ApiParam(value = "Whether to delete the segment instantly or move to deleted_segment prefix and let " | |||
There was a problem hiding this comment.
Suggested change
| @ApiParam(value = "Whether to delete the segment instantly or move to deleted_segment prefix and let " | |
| @ApiParam(value = "Whether to delete the segment without backup" |
| @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") @Encoded String segmentName) { | ||
| @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") @Encoded String segmentName, | ||
| @ApiParam(value = "Whether to delete the segment instantly or move to deleted_segment prefix and let " | ||
| + "RetentionManager handle the actual file deletion") @QueryParam("instantDelete") @DefaultValue("false") |
There was a problem hiding this comment.
Suggested change
| + "RetentionManager handle the actual file deletion") @QueryParam("instantDelete") @DefaultValue("false") | |
| ) @QueryParam("deleteWithoutBackup") @DefaultValue("false") |
There was a problem hiding this comment.
with #8176 we will be able to change the API to accept retention period, which was what you originally suggested
Suggested change
| + "RetentionManager handle the actual file deletion") @QueryParam("instantDelete") @DefaultValue("false") | |
| + @ApiParam(value = "segment delete retention period, (for example 12h, 3d); setting it to 0d will instant delete the segments") @QueryParam("deleteRetention") @DefaultValue("7d") deleteRetentionPeriod |
Codecov Report
@@ Coverage Diff @@
## master #8122 +/- ##
============================================
+ Coverage 71.01% 71.07% +0.06%
Complexity 4320 4320
============================================
Files 1626 1626
Lines 85067 85072 +5
Branches 12799 12800 +1
============================================
+ Hits 60408 60468 +60
+ Misses 20505 20449 -56
- Partials 4154 4155 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
walterddr
changed the title
walterddr
force-pushed
the
instant_delete_segment_api
branch
from
61076f5
to
0949a1b
Compare
Jackie-Jiang
approved these changes
Feb 20, 2022
xiangfu0
pushed a commit
to xiangfu0/pinot
that referenced
this pull request
Feb 23, 2022
Add deletion with retention period overwrite for segment deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per discussion in #8072, #8078 and #8176
We will add deletion with retention period overwrite for segment deletion.