ST_Within function #7990
Merged
ST_Within function #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7990 +/- ##
============================================
- Coverage 71.23% 70.33% -0.90%
- Complexity 4218 4222 +4
============================================
Files 1595 1597 +2
Lines 82743 82900 +157
Branches 12347 12369 +22
============================================
- Hits 58942 58308 -634
- Misses 19813 20591 +778
- Partials 3988 4001 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Comment on lines
77
to
79
| if (_results == null) { | ||
| _results = new int[DocIdSetPlanNode.MAX_DOC_PER_CALL]; | ||
| } |
There was a problem hiding this comment.
This is a common pattern but one I am trying to move transform functions away from - use projectionBlock.getNumDocs() in preference to DocIdSetPlanNode.MAX_DOC_PER_CALL because it might be much smaller than 10k if there is any filtering.
|
|
||
| public class StWithinFunctionTest extends GeoFunctionTest { | ||
| @Test | ||
| public void testWithin() |
Jackie-Jiang
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ST_Within function is described in the geospatial docs (https://docs.pinot.apache.org/basics/indexing/geospatial-support) but I don't think it actually exists in the code.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation