-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ConcatCollector implementation to use off-heap #6847
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6847 +/- ##
=============================================
+ Coverage 43.52% 73.53% +30.01%
- Complexity 7 12 +5
=============================================
Files 1421 1420 -1
Lines 69142 69842 +700
Branches 9987 10082 +95
=============================================
+ Hits 30093 51359 +21266
+ Misses 36504 15084 -21420
- Partials 2545 3399 +854
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good
...t-core/src/main/java/org/apache/pinot/core/segment/processing/collector/ConcatCollector.java
Outdated
Show resolved
Hide resolved
...t-core/src/main/java/org/apache/pinot/core/segment/processing/collector/ConcatCollector.java
Outdated
Show resolved
Hide resolved
...t-core/src/main/java/org/apache/pinot/core/segment/processing/collector/ConcatCollector.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/apache/pinot/core/segment/processing/collector/GenericRowSorter.java
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/util/GenericRowSerDeUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/util/GenericRowSerDeUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/util/GenericRowSerDeUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/util/GenericRowSerDeUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/util/GenericRowSerDeUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/util/GenericRowSerDeUtils.java
Outdated
Show resolved
Hide resolved
Addressed all comments @Jackie-Jiang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #6770 for motivation
Pending: This PR only changes ConcatCollector. Will update RollupCollector in a following PR.