Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean docker build cache after in vulnerability check github action job #13762

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Aug 6, 2024

Clean docker build cache after in vulnerability check github action job
Freed about 12gb building cache for next task run.

@xiangfu0 xiangfu0 added testing github_actions Pull requests that update GitHub Actions code labels Aug 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.96%. Comparing base (59551e4) to head (7678faa).
Report is 837 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13762      +/-   ##
============================================
+ Coverage     61.75%   61.96%   +0.20%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2557     +121     
  Lines        133233   141042    +7809     
  Branches      20636    21933    +1297     
============================================
+ Hits          82274    87390    +5116     
- Misses        44911    46998    +2087     
- Partials       6048     6654     +606     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.88% <ø> (+0.17%) ⬆️
java-21 61.85% <ø> (+0.23%) ⬆️
skip-bytebuffers-false 61.91% <ø> (+0.16%) ⬆️
skip-bytebuffers-true 61.83% <ø> (+34.10%) ⬆️
temurin 61.96% <ø> (+0.20%) ⬆️
unittests 61.95% <ø> (+0.20%) ⬆️
unittests1 46.38% <ø> (-0.51%) ⬇️
unittests2 27.81% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 5d825fb into apache:master Aug 6, 2024
22 checks passed
@xiangfu0 xiangfu0 deleted the clean-docker-build-cache-1 branch August 6, 2024 21:34
@gortiz
Copy link
Contributor

gortiz commented Aug 7, 2024

I guess our docker images are not very cache friendly, but shouldn't be better to try to keep the cache and remove it manually once we have issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants