TLS Port for Minion #12943
Merged
TLS Port for Minion #12943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
reviewed
Apr 17, 2024
pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12943 +/- ##
============================================
+ Coverage 61.75% 62.22% +0.47%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136466 +3233
Branches 20636 21120 +484
============================================
+ Hits 82274 84912 +2638
- Misses 44911 45279 +368
- Partials 6048 6275 +227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
reviewed
Apr 17, 2024
| @@ -116,6 +117,7 @@ public void init(PinotConfiguration config) | |||
| _instanceId = CommonConstants.Helix.PREFIX_OF_MINION_INSTANCE + _hostname + "_" + _port; | |||
| } | |||
| _listenerConfigs = ListenerConfigUtil.buildMinionConfigs(_config); | |||
| _tlsPort = ListenerConfigUtil.findLastTlsPort(_listenerConfigs, 0); | |||
There was a problem hiding this comment.
This is 0 for other participant types, shall we change for them as well?
There was a problem hiding this comment.
hmm, you mean all other components generating tls port for admin apis if not specified?
I checked broker is using -1.
xiangfu0
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a TLS port to minion, just like other components. With this, we can communicate with minion using
https. In addition to this, we should add this config to minions:And export port 9500 in the headless svc.