Add some additional metrics for Minion tasks #12710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvivekiyer
force-pushed
the
minion_observability1
branch
from
6086b1b
to
5811d06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12710 +/- ##
=============================================
- Coverage 61.75% 34.36% -27.39%
+ Complexity 207 6 -201
=============================================
Files 2436 2385 -51
Lines 133233 131008 -2225
Branches 20636 20292 -344
=============================================
- Hits 82274 45027 -37247
- Misses 44911 82654 +37743
+ Partials 6048 3327 -2721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pinot-common/src/main/java/org/apache/pinot/common/metrics/MinionMeter.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/metrics/MinionMeter.java
Outdated
Show resolved
Hide resolved
...inion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java
Outdated
Show resolved
Hide resolved
...uiltin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/plugin/minion/tasks/BaseSingleSegmentConversionExecutor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/plugin/minion/tasks/BaseSingleSegmentConversionExecutor.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/metrics/MinionMeter.java
Outdated
Show resolved
Hide resolved
vvivekiyer
force-pushed
the
minion_observability1
branch
2 times, most recently
from
adfaa7a
to
a27e660
Compare
vvivekiyer
force-pushed
the
minion_observability1
branch
from
a27e660
to
32ee93b
Compare
sajjad-moradi
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds some additional metrics for Minion tasks. Adds the following metrics:
SEGMENT_DOWNLOAD_FAIL_COUNT
SEGMENT_DOWNLOAD_COUNT
SEGMENT_UPLOAD_COUNT
SEGMENT_BYTES_DOWNLOADED
SEGMENT_BYTES_UPLOADED
RECORDS_PROCESSED_COUNT
RECORDS_PURGED_COUNT