Fixing the multiple files concurrent write issue when reloading SSLFactory #12384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12384 +/- ##
=============================================
- Coverage 61.77% 27.73% -34.04%
Complexity 207 207
=============================================
Files 2425 2425
Lines 132753 132766 +13
Branches 20535 20535
=============================================
- Hits 82005 36821 -45184
- Misses 44730 93150 +48420
+ Partials 6018 2795 -3223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Feb 8, 2024
xiangfu0
approved these changes
Feb 8, 2024
| + "on file {} changes", baseSslFactory, keyStorePath, trustStorePath, changedFile); | ||
| try { | ||
| // Need to retry a few times because when one file (key store or trust store) is updated, the other file | ||
| // (trust store or key store) may not have been fully written yet, so we need to wait a bit and retry. |
There was a problem hiding this comment.
Please also add a note that it's ok for 3 retries failure, the watcher will be triggered again and renew.
xiangfu0
changed the title
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Feb 28, 2024
…ctory (apache#12384) * add retry to SSLFactory reloading * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our tests, we found that when reloading SSLFactory, need to retry a few times because when one file (key store or trust store) is updated, the other file (trust store or key store) may not have been fully written yet, so we need to wait a bit and retry.