making nonLeaderForTables exhaustive #12345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12345 +/- ##
=============================================
- Coverage 61.69% 34.95% -26.75%
=============================================
Files 2424 2348 -76
Lines 132340 128587 -3753
Branches 20436 19875 -561
=============================================
- Hits 81651 44944 -36707
- Misses 44693 80422 +35729
+ Partials 5996 3221 -2775
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jan 31, 2024
...rc/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
Outdated
Show resolved
Hide resolved
|
I've applied changes suggested by @Jackie-Jiang and also modified the javadoc to be more specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels:
bugfixobservabilityThis PR removes a bunch of metrics that should be removed when segments are deleted.
See #12344