-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support server level consumption throttle #12292
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12292 +/- ##
============================================
+ Coverage 61.58% 61.60% +0.01%
+ Complexity 1153 1152 -1
============================================
Files 2417 2417
Lines 131611 131631 +20
Branches 20317 20318 +1
============================================
+ Hits 81057 81087 +30
+ Misses 44613 44599 -14
- Partials 5941 5945 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9aca12f
to
8c3bf4e
Compare
b3095ba
to
092af42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this!
LGTM!
QQ: This will require the server restart to change the value. Is my understanding correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple of comments though:
- Can you please update the main class documentation to reflect the new addition?
- The additional logic is straight-forward. Do we really need an integration test? Having more tests in general is good, but this test adds a few minutes to the runtime of the test suits, and I'm not sure if it's worth incurring the cost.
True, we can support the runtime change in the next PR. |
|
092af42
to
9be0311
Compare
Support server level consumption throttle:
RealtimeConsumptionRateManager
, which is inside the InstanceHolder.Release Notes: