Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null handling to sketch group-by #12259

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented Jan 11, 2024

for some reason this was hit when sketch loaded/used directly from binary

e.g.

SELECT 
  groupKey,
  distinctCountThetaSketch(rawSketchBinaryCol) -- this can some times cause group key internal null value 
FROM tbl
GROUP BY 1

so we need the null handling code path in extractGroupByResult similar to extractAggregateResult

@walterddr walterddr marked this pull request as draft January 11, 2024 16:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2e367a2) 61.55% compared to head (70e40d1) 61.56%.
Report is 1 commits behind head on master.

Files Patch % Lines
...n/DistinctCountThetaSketchAggregationFunction.java 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12259   +/-   ##
=========================================
  Coverage     61.55%   61.56%           
+ Complexity     1153     1152    -1     
=========================================
  Files          2416     2416           
  Lines        131205   131211    +6     
  Branches      20250    20252    +2     
=========================================
+ Hits          80768    80781   +13     
+ Misses        44539    44534    -5     
+ Partials       5898     5896    -2     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.51% <0.00%> (-0.01%) ⬇️
java-21 61.43% <0.00%> (-0.01%) ⬇️
skip-bytebuffers-false 61.53% <0.00%> (-0.01%) ⬇️
skip-bytebuffers-true 61.41% <0.00%> (-0.01%) ⬇️
temurin 61.56% <0.00%> (+<0.01%) ⬆️
unittests 61.56% <0.00%> (+<0.01%) ⬆️
unittests1 46.61% <0.00%> (+<0.01%) ⬆️
unittests2 27.74% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walterddr walterddr marked this pull request as ready for review January 11, 2024 17:50
@walterddr walterddr merged commit a4c3286 into apache:master Jan 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants