Fluent test framework #12215
Merged
Fluent test framework #12215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12215 +/- ##
============================================
+ Coverage 61.73% 61.76% +0.03%
+ Complexity 1152 207 -945
============================================
Files 2424 2424
Lines 132526 132526
Branches 20483 20483
============================================
+ Hits 81810 81850 +40
+ Misses 44720 44675 -45
- Partials 5996 6001 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jan 8, 2024
Merged
gortiz
force-pushed
the
fluent-test-framework
branch
from
c99a7cb
to
ff6f1ff
Compare
gortiz
force-pushed
the
fluent-test-framework
branch
from
b0380c5
to
e92d5bd
Compare
Merged
Jackie-Jiang
approved these changes
Feb 1, 2024
| import org.testng.annotations.BeforeClass; | ||
|
|
||
|
|
||
| public class AbstractAggregationFunctionTest { |
There was a problem hiding this comment.
Suggested change
| public class AbstractAggregationFunctionTest { | |
| public abstract class BaseAggregationFunctionTest { |
There was a problem hiding this comment.
Couldn't we just use abstract? We use that name pattern in several places (AbstractMetric, AbstractRule, AbstractCommand, AbstractPlanNode...) and it is also a common name in JDK (AbstractList, AbstractChronology...)
What I'm actually going to add for sure is the abstract class qualifier.
...test/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunctionTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found very difficult to understand most of the tests Pinot has. Some of them need to be complex given they are testing different service topologies or casuistics, but sometimes we just want to test a simple operator and in order to do so we need to create new classes that derive from BaseQueriesTest, which are usually not easy to read. Specially when the data the test will use is defined in csvs or other files.
This PR adds a fluent framework on top of BaseQueriesTest so we can define different tests in the same class in a fluent way that are close to the usual When-Given-Then tests.
This PR includes an example in pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunctionTest.java, although I think we can improve that test before merging this PR.
I think a framework like would be easier to read and I plan to use it to cover most of the aggregation operations in order to feel confident once I modify them to support
nullHandlingEnabled.