Fix rebalancer converge check to ensure EV is converged before reporting success #12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Dec 19, 2023
| @@ -336,7 +337,7 @@ private RebalanceResult doRebalance(TableConfig tableConfig, RebalanceConfig reb | |||
| // current instances as this is the best we can do, and can help the table get out of this state. | |||
| // 2. Only check the segments to be moved because we don't need to maintain available replicas for segments not | |||
| // being moved, including segments with all replicas OFFLINE (error segments during consumption). | |||
| Set<String> segmentsToMove = SegmentAssignmentUtils.getSegmentsToMove(currentAssignment, targetAssignment); | |||
There was a problem hiding this comment.
Why change this from set to list?
There was a problem hiding this comment.
We only need to iterate through this list and there is no deduplication needed, so changed it to list for better performance
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12182 +/- ##
=============================================
- Coverage 61.61% 34.80% -26.82%
+ Complexity 1153 6 -1147
=============================================
Files 2407 2331 -76
Lines 130920 127175 -3745
Branches 20227 19669 -558
=============================================
- Hits 80671 44266 -36405
- Misses 44362 79765 +35403
+ Partials 5887 3144 -2743
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12180
There is no easy way to add test, so added some comments explaining the logic